[TOOL-3009] Dashboard: Support all valid domains as ENS name and not just .eth #5937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Dashboard
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
🦋 Changeset detectedLatest commit: 0e2b3df The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
github-actions
bot
added
the
Playground
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5937 +/- ##
==========================================
+ Coverage 54.83% 54.85% +0.02%
==========================================
Files 1141 1142 +1
Lines 60903 60928 +25
Branches 5128 5140 +12
==========================================
+ Hits 33394 33424 +30
+ Misses 26782 26777 -5
Partials 727 727
*This pull request uses carry forward flags. Click here to find out more.
|
jnsdls
approved these changes
Jan 13, 2025
Contributor
Merge activity
|
…just .eth (#5937) <!-- start pr-codex --> ## PR-Codex overview This PR introduces the `isValidENSName` utility function to validate ENS names, replacing the previous `isEnsName` checks across multiple files. It refines address validation and enhances the overall handling of ENS names within the codebase. ### Detailed summary - Added `isValidENSName` utility function for ENS name validation. - Replaced occurrences of `isEnsName` with `isValidENSName` in various files. - Updated validation logic in components and utilities to improve address and ENS name handling. - Enhanced error messages and conditions related to ENS name checks. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces the
isValidENSNameutility function to validate ENS names across the codebase. It replaces instances ofisEnsNamewithisValidENSNameto ensure consistent validation and enhances various components and utilities to support this change.Detailed summary
isValidENSNamefunction for ENS name validation.isEnsNamewithisValidENSNamein multiple files.validateAddress,resolveAddressAndEns, and others.isValidENSNamefor ENS name checks.isValidENSNameto ensure correct functionality.